RE: [EXT] [PATCH v1] bnx2x: use generic power management

-----Original Message-----
From: Igor Russkikh <redacted>
Sent: Thursday, June 25, 2020 10:16 PM
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>; Bjorn Helgaas
[off-list ref]; Bjorn Helgaas [off-list ref];
bjorn@helgaas.com; Vaibhav Gupta [off-list ref]; David S.
Miller [off-list ref]; Jakub Kicinski [off-list ref]; Ariel Elior
[off-list ref]; Sudarsana Reddy Kalluru [off-list ref]; GR-
everest-linux-l2 [off-list ref]
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; linux-kernel-
mentees@lists.linuxfoundation.org; skhan@linuxfoundation.org
Subject: Re: [EXT] [PATCH v1] bnx2x: use generic power management



On 24/06/2020 8:51 pm, Vaibhav Gupta wrote:

quoted

External Email

----------------------------------------------------------------------
With legacy PM, drivers themselves were responsible for managing the
device's power states and takes care of register states.

After upgrading to the generic structure, PCI core will take care of
required tasks and drivers should do only device-specific operations.

The driver was also calling bnx2x_set_power_state() to set the power
state of the device by changing the device's registers' value. It is
no more needed.

Compile-tested only.

Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c  | 15 ++++++---------
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h  |  4 +---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |  3 +--
 3 files changed, 8 insertions(+), 14 deletions(-)

Acked-by: Igor Russkikh <redacted>

Sudarsana, could you please give it a short sanity test and report back?

Thanks,
  Igor

I have run the basic sanity test with these changes in the driver, didn’t see any issues.

Thanks,
Sudarsana