Thread (46 messages) 46 messages, 10 authors, 2020-06-12

Re: [PATCH v3 1/7] Documentation: dynamic-debug: Add description of level bitmask

From: Joe Perches <joe@perches.com>
Date: 2020-06-10 07:24:31
Also in: linux-acpi, linux-arm-msm, linux-btrfs, linux-doc, linux-media, lkml

On Wed, 2020-06-10 at 09:09 +0200, Greg Kroah-Hartman wrote:
On Tue, Jun 09, 2020 at 11:35:31PM -0700, Joe Perches wrote:
quoted
On Wed, 2020-06-10 at 08:31 +0200, Greg Kroah-Hartman wrote:
quoted
On Tue, Jun 09, 2020 at 09:58:07AM -0700, Joe Perches wrote:
quoted
On Tue, 2020-06-09 at 13:16 +0200, Greg Kroah-Hartman wrote:
quoted
What is wrong with the existing control of dynamic
debug messages that you want to add another type of arbitrary grouping
to it? 
There is no existing grouping mechanism.
info/warn/err/dbg is what I am referring to.
This is specifically about dbg so that's not relevant is it.
But each "level" you all come up with will be intrepreted differently
per driver, causing total confusion (like we have today.)  Try to make
it better by just removing that mess.
Or add value as it allows the developer to do what's
necessary for their development.
quoted
quoted
In the beginning, yes, adding loads of different types of debugging
options to a driver is needed by the author, but by the time it is added
to the kernel, all of that should be able to be removed and only a
single "enable debug" should be all that is needed.
No one does that.
We did that for USB drivers a decade ago, it can be done.
And nearly no one does it.

btw: look up usbip_debug_flag and usbip_dbg_<foo> or the uhci driver

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help