On 6/8/20 12:52 PM, Anchal Agarwal wrote:

quoted

quoted

quoted

quoted

+void xen_hvm_map_shared_info(void)
+{
+     xen_hvm_init_shared_info();
+     if (shared_info_pfn)
+             HYPERVISOR_shared_info = __va(PFN_PHYS(shared_info_pfn));
+}
+

AFAICT it is only called once so I don't see a need for new routine.

HYPERVISOR_shared_info can only be mapped in this scope without refactoring
much of the code.

Refactoring what? All am suggesting is

shared_info_pfn does not seem to be in scope here, it's scope is limited
to enlighten_hvm.c. That's the reason I introduced a new function there.

OK, that's a good point.


-boris