Thread (2 messages) flat view 2 messages, 2 authors, 2020-06-01

RE: [Intel-wired-lan] [PATCH] [net-next] e1000e: fix unused-function warning

From: Brown, Aaron F <hidden>
Date: 2020-06-01 17:09:06
Also in: intel-wired-lan, lkml

From: Intel-wired-lan <redacted> On Behalf Of Arnd
Bergmann
Sent: Wednesday, May 27, 2020 6:47 AM
To: Kirsher, Jeffrey T <redacted>; David S. Miller
[off-list ref]; Jakub Kicinski [off-list ref]; Lifshits, Vitaly
[off-list ref]
Cc: Arnd Bergmann <arnd@arndb.de>; Konstantin Khlebnikov
[off-list ref]; netdev@vger.kernel.org; Wysocki, Rafael J
[off-list ref]; linux-kernel@vger.kernel.org; intel-wired-
lan@lists.osuosl.org; Alexander Duyck [off-list ref]
Subject: [Intel-wired-lan] [PATCH] [net-next] e1000e: fix unused-function
warning

The CONFIG_PM_SLEEP #ifdef checks in this file are inconsistent,
leading to a warning about sometimes unused function:

drivers/net/ethernet/intel/e1000e/netdev.c:137:13: error: unused function
'e1000e_check_me' [-Werror,-Wunused-function]

Rather than adding more #ifdefs, just remove them completely
and mark the PM functions as __maybe_unused to let the compiler
work it out on it own.

Fixes: e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/intel/e1000e/netdev.c | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)
Tested-by: Aaron Brown <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help