Thread (5 messages) 5 messages, 2 authors, 2020-06-30

Re: [PATCH net-next v2 1/3] cxgb4: add mirror action to TC-MATCHALL offload

From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-06-30 00:34:15

On Tue, 30 Jun 2020 04:19:51 +0530 Rahul Lakkireddy wrote:
+	if (refcount_read(&pi->vi_mirror_refcnt) > 1) {
+		refcount_dec(&pi->vi_mirror_refcnt);
+		goto out_unlock;
+	}
Please remove the use of refcount_t if you're doing this, otherwise a
person looking at this code will waste time trying to validate if this
clearly bogus use of refcount_t is harmless or not.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help