On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote:

From: Alice Michael <redacted>

Implement mailbox setup, take down, and commands.

[]

[]

Multiple functions using **cp and *cp can be error prone.

 {
-	/* stub */
+	enum iecm_status status = 0;
+	bool is_rxq = false;
+
+	if (!qinfo->len || !qinfo->buf_size ||
+	    qinfo->len > IECM_CTLQ_MAX_RING_SIZE ||
+	    qinfo->buf_size > IECM_CTLQ_MAX_BUF_LEN)
+		return IECM_ERR_CFG;
+
+	*cq = kcalloc(1, sizeof(struct iecm_ctlq_info), GFP_KERNEL);
+	if (!(*cq))
+		return IECM_ERR_NO_MEMORY;

pity there is an iecm_status and not just a generic -ENOMEM.
Is there much value in the separate enum?

[]

@@ -152,7 +388,58 @@ enum iecm_status iecm_ctlq_clean_sq(struct iecm_ctlq_info *cq,

 				    u16 *clean_count,
 				    struct iecm_ctlq_msg *msg_status[])
 {
-	/* stub */
+	enum iecm_status ret = 0;
+	struct iecm_ctlq_desc *desc;
+	u16 i = 0, num_to_clean;
+	u16 ntc, desc_err;
+
+	if (!cq || !cq->ring_size)
+		return IECM_ERR_CTLQ_EMPTY;
+
+	if (*clean_count == 0)
+		return 0;
+	else if (*clean_count > cq->ring_size)
+		return IECM_ERR_PARAM;

unnecessary else

		if (cq->bi.rx_buff[ntp])
			continue;

and unindent?

+			if (!buffs_avail) {
+				/* If the caller hasn't given us any buffers or
+				 * there are none left, search the ring itself
+				 * for an available buffer to move to this
+				 * entry starting at the next entry in the ring
+				 */
+				tbp = ntp + 1;
+
+				/* Wrap ring if necessary */
+				if (tbp >= cq->ring_size)
+					tbp = 0;
+
+				while (tbp != cq->next_to_clean) {
+					if (cq->bi.rx_buff[tbp]) {
+						cq->bi.rx_buff[ntp] =
+							cq->bi.rx_buff[tbp];
+						cq->bi.rx_buff[tbp] = NULL;
+
+						/* Found a buffer, no need to
+						 * search anymore
+						 */
+						break;
+					}
+
+					/* Wrap ring if necessary */
+					tbp++;
+					if (tbp >= cq->ring_size)
+						tbp = 0;
+				}
+
+				if (tbp == cq->next_to_clean)
+					goto post_buffs_out;
+			} else {
+				/* Give back pointer to DMA buffer */
+				cq->bi.rx_buff[ntp] = buffs[i];
+				i++;
+
+				if (i >= *buff_count)
+					buffs_avail = false;
+			}
+		}
+
+		desc->flags =
+			cpu_to_le16(IECM_CTLQ_FLAG_BUF | IECM_CTLQ_FLAG_RD);
+
+		/* Post buffers to descriptor */
+		desc->datalen = cpu_to_le16(cq->bi.rx_buff[ntp]->size);
+		desc->params.indirect.addr_high =
+			cpu_to_le32(IECM_HI_DWORD(cq->bi.rx_buff[ntp]->pa));
+		desc->params.indirect.addr_low =
+			cpu_to_le32(IECM_LO_DWORD(cq->bi.rx_buff[ntp]->pa));
+
+		ntp++;
+		if (ntp == cq->ring_size)
+			ntp = 0;
+	}

[] 

missing format terminating newlines

+			status = IECM_ERR_CFG;
+		} else {
+			status = 0;
+		}
+	} else {
+		/* Timeout occurred */
+		status = IECM_ERR_NOT_READY;
+		dev_err(&adapter->pdev->dev, "VC timeout, state = %u", state);

here too