Hi Andrew,

we are going to update the commit message with:

    LR, ER and FR are defined as a single link mode because they are
    using same technology and by design are fully interoperable.
    EEPROM content indicates if the module is LR, ER, or FR, and the
    user space ethtool decoder is planned to support decoding these    
    modes in the EEPROM.

Please let me know it this answer your questions, so we can re-spin
this patch.

Hi Saeed.

This looks good to me.

Thanks
	Andrew