Also, there is already a precedent of a PCS module (mdio-xpcs.c, the
model of which I have followed) and without also changing that
(which I am not comfortable doing) there is no point of changing
this one.

I don't give this much value. You often need a couple of
implementation before you can see what the right structure should
be. And then you refactor. Jose is pretty active, and will probably
help refactor his driver if we ask him.

     Andrew