Thread (26 messages) 26 messages, 5 authors, 2020-06-03

Re: [RFC PATCH net-next 0/3] TC: Introduce qevents

From: Petr Machata <hidden>
Date: 2020-06-01 22:37:35

Cong Wang [off-list ref] writes:
On Mon, Jun 1, 2020 at 6:40 AM Jiri Pirko [off-list ref] wrote:
quoted
The first command just says "early drop position should be processed by
block 10"

The second command just adds a filter to the block 10.
This is exactly why it looks odd to me, because it _reads_ like
'tc qdisc' creates the block to hold tc filters... I think tc filters should
create whatever placeholder for themselves.
Look at clsact. It creates blocks in exactly the same way.
I know in memory block (or chain or filters) are stored in qdisc, but
it is still different to me who initiates the creation.
The block binding mechanics are not new. The patch just reuses them. If
you are unhappy about how this is currently done, I too would see merit
in creating a block explicitly, like with chains. But it has nothing to
do with this patchset, which would just naturally pick up whatever this
new mechanic is.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help