Re: [PATCH bpf-next 8/8] selftests/bpf: Add tests for attaching bpf_link to netns
From: Andrii Nakryiko <hidden>
Date: 2020-05-28 06:08:38
Also in:
bpf
On Wed, May 27, 2020 at 12:16 PM Jakub Sitnicki [off-list ref] wrote:
Extend the existing test case for flow dissector attaching to cover: - link creation, - link updates, - link info querying, - mixing links with direct prog attachment. Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com> ---
You are not using bpf_program__attach_netns() at all. Would be nice to actually use higher-level API here... Also... what's up with people using CHECK_FAIL + perror instead of CHECK? Is CHECK being avoided for some reason or people are just not aware of it (which is strange, because CHECK was there before CHECK_FAIL)?
.../bpf/prog_tests/flow_dissector_reattach.c | 500 +++++++++++++++++- 1 file changed, 471 insertions(+), 29 deletions(-)
[...]