Re: [PATCH v9 bpf-next 2/3] libbpf: add support for command BPF_ENABLE_STATS

On Mon, May 4, 2020 at 10:47 AM Song Liu [off-list ref] wrote:

quoted

On May 2, 2020, at 1:00 PM, Alexei Starovoitov [off-list ref] wrote:

On Thu, Apr 30, 2020 at 12:15 AM Song Liu [off-list ref] wrote:

quoted

bpf_enable_stats() is added to enable given stats.

Signed-off-by: Song Liu <redacted>

...

quoted

diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
index 335b457b3a25..1901b2777854 100644
--- a/tools/lib/bpf/bpf.h
+++ b/tools/lib/bpf/bpf.h

@@ -231,6 +231,7 @@ LIBBPF_API int bpf_load_btf(void *btf, __u32 btf_size, char *log_buf,

LIBBPF_API int bpf_task_fd_query(int pid, int fd, __u32 flags, char *buf,
                                __u32 *buf_len, __u32 *prog_id, __u32 *fd_type,
                                __u64 *probe_offset, __u64 *probe_addr);
+LIBBPF_API int bpf_enable_stats(enum bpf_stats_type type);

I see odd warning here while building selftests

In file included from runqslower.c:10:
.../tools/testing/selftests/bpf/tools/include/bpf/bpf.h:234:38:
warning: ‘enum bpf_stats_type’ declared inside parameter list will not
be visible outside of this definition or declaration
 234 | LIBBPF_API int bpf_enable_stats(enum bpf_stats_type type);

Since this warning is printed only when building runqslower
and the rest of selftests are fine, I'm guessing
it's a makefile issue with order of includes?

Andrii, could you please take a look ?
Not urgent. Just flagging for visibility.

The following should fix it.

Thanks,
Song

=========================== 8< ==============================

From 485c28c8e2cbcc22aa8fcda82f8f599411faa755 Mon Sep 17 00:00:00 2001
From: Song Liu <redacted>
Date: Mon, 4 May 2020 10:36:26 -0700
Subject: [PATCH bpf-next] runqslower: include proper uapi/bpf.h

runqslower doesn't specify include path for uapi/bpf.h. This causes the
following warning:

In file included from runqslower.c:10:
.../tools/testing/selftests/bpf/tools/include/bpf/bpf.h:234:38:
warning: 'enum bpf_stats_type' declared inside parameter list will not
be visible outside of this definition or declaration
  234 | LIBBPF_API int bpf_enable_stats(enum bpf_stats_type type);

Fix this by adding -I tools/includ/uapi to the Makefile.

Reported-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Song Liu <redacted>
---

LGTM. Thanks!

Acked-by: Andrii Nakryiko <redacted>