Re: [greybus-dev] [PATCH 8/8] net/iucv: Use the new device_to_pm() helper to access struct dev_pm_ops

From
Alex Elder <hidden>
Date
2020-05-26 16:48:18
Also in
linux-acpi, linux-pci, linux-pm, linux-s390, linux-scsi, linux-usb
Reply to
Krzysztof Wilczyński, 2020-05-26
On 5/26/20 10:07 AM, Krzysztof Wilczyński wrote:
Hello Greg,

[...]
quoted
It's "interesting" how using your new helper doesn't actually make the
code smaller.  Perhaps it isn't a good helper function?
Helper functions often improve code readability, which is
beneficial even if it doesn't reduce code size or efficiency.

But I won't argue for or against this particular change.
It's OK with me either way.

					-Alex
The idea for the helper was inspired by the comment Dan made to Bjorn
about Bjorn's change, as per:

   https://lore.kernel.org/driverdev-devel/20191016135002.GA24678@kadam/ (local)

It looked like a good idea to try to reduce the following:

   dev->driver && dev->driver->pm && dev->driver->pm->prepare

Into something more succinct.  Albeit, given the feedback from yourself
and Rafael, I gather that this helper is not really a good addition.

Thank you everyone and sorry for the commotion!

Krzysztof
_______________________________________________
greybus-dev mailing list
greybus-dev@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/greybus-dev
  
Thread (26 messages) 26 messages, 7 authors, last reply 2020-05-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help