Re: [PATCH net-next] xfrm: no-anti-replay protection flag
From: Petr Vaněk <hidden>
Date: 2020-05-30 12:41:14
Also in:
lkml
From: Petr Vaněk <hidden>
Date: 2020-05-30 12:41:14
Also in:
lkml
Hi Christophe, On Wed, May 27, 2020 at 07:11:21PM +0200, Christophe Gouault wrote:
This patch is useful, however I think you should change the name of the option and amend its description: the option does not disable anti-replay in output (it can only be disabled in input), it allows the output sequence number to wrap, and it assumes that the remote peer disabled anti-replay in input. So you I suggest you change the name of the option to something like XFRM_SA_XFLAG_OSEQ_MAY_WRAP or XFRM_SA_XFLAG_ALLOW_OSEQ_WRAP.
thank you for your suggestions, I changed the patch and sent the second version. Petr