Re: [PATCH v2 1/2] regmap: provide helpers for simple bit operations

From
Mark Brown <broonie@kernel.org>
Date
2020-05-28 14:45:06
Also in
linux-arm-kernel, linux-mediatek, lkml
Reply to
Bartosz Golaszewski, 2020-05-28
On Thu, May 28, 2020 at 04:22:40PM +0200, Bartosz Golaszewski wrote:
+	return (val & bits) == bits ? 1 : 0;
The tenery here is redundant, it's converting a boolean value into a
boolean value.  Otherwise this looks good.

Attachments

Thread (6 messages) 6 messages, 3 authors, last reply 2020-05-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help