Re: [PATCH 1/2] regmap: provide helpers for simple bit operations
From: Bartosz Golaszewski <hidden>
Date: 2020-05-28 13:32:56
Also in:
linux-arm-kernel, linux-mediatek, lkml
From: Bartosz Golaszewski <hidden>
Date: 2020-05-28 13:32:56
Also in:
linux-arm-kernel, linux-mediatek, lkml
czw., 28 maj 2020 o 15:29 Mark Brown [off-list ref] napisał(a):
On Thu, May 28, 2020 at 02:34:58PM +0200, Bartosz Golaszewski wrote:quoted
This adds three new macros for simple bit operations: set_bits, clear_bits and test_bits.Why macros and not static inlines?
The existing regmap_update_bits_*() helpers are macros too, so I tried to stay consistent. Any reason why they are macros and not static inlines? If there's none, then why not convert them too? Otherwise we'd have a static inline expanding a macro which in turn is calling a function (regmap_update_bits_base()). Bartosz