Re: [PATCH -net-next] net: psample: depends on INET

On 5/22/20 12:17 PM, Cong Wang wrote:

On Fri, May 22, 2020 at 12:03 PM Randy Dunlap [off-list ref] wrote:

quoted

From: Randy Dunlap <rdunlap@infradead.org>

Fix psample build error when CONFIG_INET is not set/enabled.
PSAMPLE should depend on INET instead of NET since
ip_tunnel_info_opts() is only present for CONFIG_INET.

../net/psample/psample.c: In function ‘__psample_ip_tun_to_nlattr’:
../net/psample/psample.c:216:25: error: implicit declaration of function ‘ip_tunnel_info_opts’; did you mean ‘ip_tunnel_info_opts_set’? [-Werror=implicit-function-declaration]

Or just make this tunnel support optional. psample does not
require it to function correctly.

Sure, I thought of that, but it's not clear to me which bits of it
to make optional, so I'll leave it for its maintainer to handle.

thanks.
-- 
~Randy