Thread (2 messages) flat view 2 messages, 2 authors, 2020-05-21

RE: [PATCH] e1000e: Disable TSO for buffer overrun workaround

From: Brown, Aaron F <hidden>
Date: 2020-05-21 07:18:42
Also in: intel-wired-lan, lkml

From: netdev-owner@vger.kernel.org <redacted> On
Behalf Of Kai-Heng Feng
Sent: Thursday, May 7, 2020 7:21 AM
To: Kirsher, Jeffrey T <redacted>
Cc: Kai-Heng Feng <redacted>; David S. Miller
[off-list ref]; Neftin, Sasha [off-list ref]; Dima
Ruinskiy [off-list ref]; Avargil, Raanan
[off-list ref]; moderated list:INTEL ETHERNET DRIVERS <intel-
wired-lan@lists.osuosl.org>; open list:NETWORKING DRIVERS
[off-list ref]; open list [off-list ref]
Subject: [PATCH] e1000e: Disable TSO for buffer overrun workaround

Commit b10effb92e27 ("e1000e: fix buffer overrun while the I219 is
processing DMA transactions") imposes roughly 30% performance penalty.

The commit log states that "Disabling TSO eliminates performance loss
for TCP traffic without a noticeable impact on CPU performance", so
let's disable TSO by default to regain the loss.

Fixes: b10effb92e27 ("e1000e: fix buffer overrun while the I219 is processing
DMA transactions")
BugLink: https://bugs.launchpad.net/bugs/1802691
Signed-off-by: Kai-Heng Feng <redacted>
---
 drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++++
 1 file changed, 4 insertions(+)
Tested-by: Aaron Brown <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help