Re: [PATCH] security: fix the default value of secid_to_secctx hook

From
Casey Schaufler <casey@schaufler-ca.com>
Date
2020-05-18 22:02:16
Also in
bpf, linux-security-module, lkml
Reply to
Schaufler, Casey, 2020-05-18
On 5/18/2020 2:43 PM, Schaufler, Casey wrote:
quoted
-----Original Message-----
From: <redacted> <linux-kernel-
owner@vger.kernel.org> On Behalf Of Arnd Bergmann
Sent: Saturday, May 16, 2020 1:05 AM
To: Alexei Starovoitov <redacted>
Cc: James Morris <redacted>; Anders Roxell
[off-list ref]; Alexei Starovoitov [off-list ref]; Daniel
Borkmann [off-list ref]; LKML [off-list ref];
Network Development [off-list ref]; bpf
[off-list ref]
Subject: Re: [PATCH] security: fix the default value of secid_to_secctx hook
I would *really* appreciate it if discussions about the LSM infrastructure
where done on the linux-security-module mail list. (added to CC).
quoted
On Sat, May 16, 2020 at 1:29 AM Alexei Starovoitov
[off-list ref] wrote:
quoted
On Thu, May 14, 2020 at 12:47 PM Alexei Starovoitov
[off-list ref] wrote:
quoted
On Thu, May 14, 2020 at 12:43 PM James Morris
[off-list ref] wrote:
quoted
On Wed, 13 May 2020, Alexei Starovoitov wrote:
quoted
James,

since you took the previous similar patch are you going to pick this
one up as well?
Or we can route it via bpf tree to Linus asap.
Routing via your tree is fine.
Perfect.
Applied to bpf tree. Thanks everyone.
Looks like it was a wrong fix.
It breaks audit like this:
sudo auditctl -e 0
[   88.400296] audit: error in audit_log_task_context
[   88.400976] audit: error in audit_log_task_context
[   88.401597] audit: type=1305 audit(1589584951.198:89): op=set
audit_enabled=0 old=1 auid=0 ses=1 res=0
[   88.402691] audit: type=1300 audit(1589584951.198:89):
arch=c000003e syscall=44 success=yes exit=52 a0=3 a1=7ffe42a37400
a2=34 a3=0 items=0 ppid=2250 pid=2251 auid=0 uid=0 gid=0 euid=0 suid=0
fsuid=0 egid=0 sgid=0 fsgid=0 tty=ttyS0 se)
[   88.405587] audit: type=1327 audit(1589584951.198:89):
proctitle=617564697463746C002D650030
Error sending enable request (Operation not supported)

when CONFIG_LSM= has "bpf" in it.
Do you have more than one LSM enabled? It looks like
the problem with security_secid_to_secctx() is now that it
returns an error if any of the LSMs fail and the caller expects
it to succeed if at least one of them sets the secdata pointer.
security_secid_to_secctx() is not currently stackable (I'm
looking at 5.7-rc6) even for this simple case. call_int_hook()
does bail-on-fail and will try all hooks registered, looking for
a failure.

You need to replace the call_int_hook() with an explicit
hlist_for_each_entry(), as is done in security_inode_getsecurity().
quoted
The problem earlier was that the call succeeded even though
no LSM had set the pointer.

What is the behavior we actually expect from this function if
multiple LSM are loaded?

       Arnd
  
Thread (9 messages) 9 messages, 7 authors, last reply 2020-05-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help