Thread (76 messages) 76 messages, 10 authors, 2020-05-20

Re: [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover

From: David Howells <dhowells@redhat.com>
Date: 2020-05-15 15:15:46
Also in: ceph-devel, linux-block, linux-cifs, linux-nfs, linux-nvme, linux-rdma, linux-sctp, lkml, ocfs2-devel, target-devel

Christoph Hellwig [off-list ref] wrote:
quoted
quoted
+		ip_sock_set_mtu_discover(conn->params.local->socket->sk,
+				IP_PMTUDISC_DONT);
Um... The socket in question could be an AF_INET6 socket, not an AF_INET4
socket - I presume it will work in that case.  If so:
Yes, the implementation of that sockopt, including the inet_sock
structure where these options are set is shared between ipv4 and ipv6.
Great!  Could you note that either in the patch description or in the
kerneldoc attached to the function?

Thanks,
David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help