Re: [PATCH net-next v2] checkpatch: warn about uses of ENOTSUPP

From
Jakub Kicinski <kuba@kernel.org>
Date
2020-05-11 17:07:56
Also in
lkml
Reply to
Joe Perches, 2020-05-11
On Mon, 11 May 2020 10:03:31 -0700 Joe Perches wrote:
On Mon, 2020-05-11 at 09:53 -0700, Jakub Kicinski wrote:
quoted
ENOTSUPP often feels like the right error code to use, but it's
in fact not a standard Unix error. E.g.:  
[]
quoted
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl  
[]
quoted
@@ -4199,6 +4199,17 @@ sub process {
 			     "ENOSYS means 'invalid syscall nr' and nothing else\n" . $herecurr);
 		}
 
+# ENOTSUPP is not a standard error code and should be avoided in new patches.
+# Folks usually mean EOPNOTSUPP (also called ENOTSUP), when they type ENOTSUPP.
+# Similarly to ENOSYS warning a small number of false positives is expected.
+		if (~$file && $line =~ /\bENOTSUPP\b/) {  
It's probably my typo or my brain thinking "not" and hitting
the tilde and not the bang, but this should be

		if (!$file & ...)
Ahh! :)
Otherwise:

Acked-by: Joe Perches <joe@perches.com>
Thanks!
Thread (3 messages) 3 messages, 2 authors, last reply 2020-05-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help