Re: [PATCH net-next 3/5] net: hns3: provide .get_cmdq_stat interface for the client
From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-05-11 02:47:09
Also in:
lkml
On Mon, 11 May 2020 08:13:06 +0800 tanhuazhong wrote:
On 2020/5/10 4:48, Jakub Kicinski wrote:quoted
On Sat, 9 May 2020 17:27:39 +0800 Huazhong Tan wrote:quoted
diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.h b/drivers/net/ethernet/hisilicon/hns3/hnae3.h index 5602bf2..7506cab 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hnae3.h +++ b/drivers/net/ethernet/hisilicon/hns3/hnae3.h@@ -552,6 +552,7 @@ struct hnae3_ae_ops { int (*set_vf_mac)(struct hnae3_handle *handle, int vf, u8 *p); int (*get_module_eeprom)(struct hnae3_handle *handle, u32 offset, u32 len, u8 *data); + bool (*get_cmdq_stat)(struct hnae3_handle *handle); };I don't see anything in this series using this new interface, why is it added now?This interface is needed by the roce client, whose patch will be upstreamed to the rdma tree, it is other branch. So we provide this interface previously, then the rdma guy will upstream their patch later, maybe linux-5.8-rc*.
Understood. Please make sure to include this kind of information in the cover letter in the future.