Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

On Tue, 05 May 2020 12:00:49 -0700 (PDT) David Miller [off-list ref] wrote:

From: David Miller <davem@davemloft.net>
Date: Tue, 05 May 2020 11:48:25 -0700 (PDT)

quoted

Series applied and queued up for -stable, thanks.

Nevermind, this doesn't even compile.

net/smc/af_smc.c: In function ‘smc_switch_to_fallback’:
net/smc/af_smc.c:473:19: error: ‘smc->clcsock->wq’ is a pointer; did you mean to use ‘->’?
  473 |   smc->clcsock->wq.fasync_list =
      |                   ^
      |                   ->
net/smc/af_smc.c:474:25: error: ‘smc->sk.sk_socket->wq’ is a pointer; did you mean to use ‘->’?
  474 |    smc->sk.sk_socket->wq.fasync_list;
      |                         ^
      |                         ->

So I had to revert these changes.

When you make a change of this magnitude and scope you must do an
allmodconfig build.

Definitely my fault.  I will fix this in next spin.


Thanks,
SeongJae Park

Thank you.