Re: [PATCH net 0/2] Revert the 'socket_alloc' life cycle change
From: Al Viro <viro@zeniv.linux.org.uk>
Date: 2020-05-05 12:44:56
Also in:
lkml
On Tue, May 05, 2020 at 09:28:39AM +0200, SeongJae Park wrote:
From: SeongJae Park <redacted>
The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
deallocation of 'socket_alloc' to be done asynchronously using RCU, as
same to 'sock.wq'. And the following commit 333f7909a857 ("coallocate
socket_sq with socket itself") made those to have same life cycle.
The changes made the code much more simple, but also made 'socket_alloc'
live longer than before. For the reason, user programs intensively
repeating allocations and deallocations of sockets could cause memory
pressure on recent kernels.
To avoid the problem, this commit reverts the changes.Is it "could cause" or is it "have been actually observed to"?