Thread (1 message) 1 message, 1 author, 2020-05-05

Re: [v3] nfp: abm: Fix incomplete release of system resources in nfp_abm_vnic_set_mac()

From: Markus Elfring <hidden>
Date: 2020-05-05 05:48:31
Also in: lkml

Thanks for your feedback, and yes, I'd like to further adjust the description details
to make the patch more clear and better.
Thanks for such a positive response.

But because Jakub seems to prefer v1, so I'm somehow confused
Such a view can be reasonable.
The change acceptance varies between involved contributors.

if I should submit a new version based on v1
Such a choice depends also on your willingness to clarify and improve
the software situation by better commit messages.

or based on the version that has an addition of a jump target?
I propose that you can offer patch series with two update steps (for example)
according to the affected function implementation.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=47cf1b422e6093aee2a3e55d5e162112a2c69870#n102

1. Add a missing function call for the completion of the desired resource clean-up.

2. Adjust a bit of exception handling code so that it can be better reused
   at the end of this function.
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=47cf1b422e6093aee2a3e55d5e162112a2c69870#n450


I am curious if you are going to answer (my) previous questions and suggestions
(in constructive ways).

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help