Re: [PATCH] net: enetc: fix an issue about leak system resources

From: Markus Elfring <hidden>
Date: 2020-05-04 14:12:30
Also in: lkml

the related system resources were not released when enetc_hw_alloc()
return error in the enetc_pci_mdio_probe(), add iounmap() for error
handling label "err_hw_alloc" to fix it.
How do you think about a wording variant like the following?

   Subject:
   [PATCH v2] net: enetc: Complete exception handling in enetc_pci_mdio_probe()

   Change description:
   A call of the function “enetc_hw_alloc” can fail here.
   The corresponding system resources were not released then.
   Thus move a call of the function “iounmap” behind
   the label “err_hw_alloc”.


Would you like to reduce the labels for this function implementation instead?

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help