Re: [PATCH net-next 1/2] net: dsa: sja1105: suppress -Wmissing-prototypes in sja1105_static_config.c
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2020-05-30 18:40:45
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2020-05-30 18:40:45
On 5/30/2020 3:29 AM, Vladimir Oltean wrote:
From: Vladimir Oltean <vladimir.oltean@nxp.com> Newer compilers complain with W=1 builds that there are non-static functions defined in sja1105_static_config.c that don't have a prototype, because their prototype is defined in sja1105.h which this translation unit does not include. I don't entirely understand what is the point of these warnings, since in principle there's nothing wrong with that. But let's move the prototypes to a header file that _is_ included by sja1105_static_config.c, since that will make these warnings go away. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian