Tue, May 26, 2020 at 06:26:44PM CEST, vadym.kochan@plvision.eu wrote:

On Mon, May 11, 2020 at 01:23:46PM +0200, Jiri Pirko wrote:

quoted

Fri, May 01, 2020 at 01:20:49AM CEST, vadym.kochan@plvision.eu wrote:

quoted

Add PCI interface driver for Prestera Switch ASICs family devices, which
provides:

[...]

quoted

This looks very specific. Is is related to 0xC804?

Sorry, I missed this question. But I am not sure I got it.

Is 0xC804 pci id of "Prestera AC3x 98DX326x"? If so and in future you
add support for another chip/revision to this driver, the name "Prestera
AC3x 98DX326x" would be incorrect. I suggest to use some more generic
name, like "Prestera".

quoted

quoted

+	.id_table = prestera_pci_devices,
+	.probe    = prestera_pci_probe,
+	.remove   = prestera_pci_remove,
+};
+
+static int __init prestera_pci_init(void)
+{
+	return pci_register_driver(&prestera_pci_driver);
+}
+
+static void __exit prestera_pci_exit(void)
+{
+	pci_unregister_driver(&prestera_pci_driver);
+}
+
+module_init(prestera_pci_init);
+module_exit(prestera_pci_exit);
+
+MODULE_AUTHOR("Marvell Semi.");

Author is you, not a company.

quoted

+MODULE_LICENSE("Dual BSD/GPL");
+MODULE_DESCRIPTION("Marvell Prestera switch PCI interface");
-- 
2.17.1