On Thu, May 21, 2020 at 03:09:57PM -0700, Jacob Keller wrote:

On 5/21/2020 2:51 PM, Jakub Kicinski wrote:

quoted

On Thu, 21 May 2020 13:59:32 -0700 Jacob Keller wrote:

quoted

quoted

quoted

So the ice firmware can optionally send diagnostic debug messages via
its control queue. The current solutions we've used internally
essentially hex-dump the binary contents to the kernel log, and then
these get scraped and converted into a useful format for human consumption.

I'm not 100% of the format, but I know it's based on a decoding file
that is specific to a given firmware image, and thus attempting to tie
this into the driver is problematic.  

You explained how it works, but not why it's needed :)  

Well, the reason we want it is to be able to read the debug/diagnostics
data in order to debug issues that might be related to firmware or
software mis-use of firmware interfaces.

By having it be a separate interface rather than trying to scrape from
the kernel message buffer, it becomes something we can have as a
possibility for debugging in the field.

For pure debug/tracing perhaps trace_devlink_hwerr() is the right fit?

Right Ido?

Hm, yes that might be more suitable for this purpose. I'll take a look
at it!

Jacob, here is more context that might help:

https://lore.kernel.org/netdev/20191103083554.6317-1-idosch@idosch.org/ (local)
https://lore.kernel.org/netdev/20191112064830.27002-1-idosch@idosch.org/ (local)

Thanks,
Jake