Thread (21 messages) 21 messages, 3 authors, 2020-05-04

Re: [PATCH V7 mlx5-next 00/16] Add support to get xmit slave

From: Jarod Wilson <hidden>
Date: 2020-05-04 14:36:27
Also in: linux-rdma

On Thu, Apr 30, 2020 at 2:50 PM Maor Gottlieb [off-list ref] wrote:
Hi Dave,

This series is a combination of netdev and RDMA, so in order to avoid
conflicts, we would like to ask you to route this series through
mlx5-next shared branch. It is based on v5.7-rc2 tag.

---------------------------------------------------------------------

The following series adds support to get the LAG master xmit slave by
introducing new .ndo - ndo_get_xmit_slave. Every LAG module can
implement it and it first implemented in the bond driver.
This is follow-up to the RFC discussion [1].

The main motivation for doing this is for drivers that offload part
of the LAG functionality. For example, Mellanox Connect-X hardware
implements RoCE LAG which selects the TX affinity when the resources
are created and port is remapped when it goes down.

The first part of this patchset introduces the new .ndo and add the
support to the bonding module.

The second part adds support to get the RoCE LAG xmit slave by building
skb of the RoCE packet based on the AH attributes and call to the new
.ndo.

The third part change the mlx5 driver driver to set the QP's affinity
port according to the slave which found by the .ndo.
At a glance, I'm not sure why all the "get the xmit slave" functions
are being passed an skb. None of them should be manipulating the skb,
that should all be done in the respective xmit functions after the
slave has been returned.

--
Jarod Wilson
jarod@redhat.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help