Re: [PATCH net-next v2 2/9] dt-bindings: net: add backplane dt bindings

From
Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date
2020-04-25 10:27:19
Also in
linux-devicetree, linux-doc, lkml
Reply to
Florinel Iordache, 2020-04-24
On Fri, Apr 24, 2020 at 03:46:24PM +0300, Florinel Iordache wrote:
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
index ac471b6..541cee5 100644
--- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
@@ -93,8 +93,9 @@ properties:
       - rxaui
       - xaui
 
-      # 10GBASE-KR, XFI, SFI
+      # 10GBASE-KR, 40GBASE-KR4, XFI, SFI
       - 10gbase-kr
+      - 40gbase-kr4
       - usxgmii
This makes a nonsense of the comment (and is actually something I failed
to update with the 10GBASE-R change).

The comment "10GBASE-KR, XFI, SFI" was there to describe _only_ the
following option, so your addition should look like:

	# 10GBASE-KR, XFI, SFI
	- 10gbase-kr
	# 40GBASE-KR4
	- 40gbase-kr4

Whereas there should also be a fix for the lack of 10GBASE-R, so it
should finally look like this:

	# 10GBASE-R, XFI, SFI
	- 10gbase-r
	# 10GBASE-KR (10GBASE-R with backplane negotiation)
	- 10gbase-kr
	# 40GBASE-KR4 (...)
	- 40gbase-kr4

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
Thread (20 messages) 20 messages, 4 authors, last reply 2020-04-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help