Thread (4 messages) 4 messages, 2 authors, 2020-03-25

Re: [PATCH] netfilter: nft_fwd_netdev: Fix CONFIG_NET_CLS_ACT=n build

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2020-03-25 10:40:08
Also in: linux-next, netfilter-devel

On Wed, Mar 25, 2020 at 10:33:00AM +0100, Geert Uytterhoeven wrote:
If CONFIG_NET_CLS_ACT=n:

    net/netfilter/nft_fwd_netdev.c: In function ‘nft_fwd_netdev_eval’:
    net/netfilter/nft_fwd_netdev.c:32:10: error: ‘struct sk_buff’ has no member named ‘tc_redirected’
      pkt->skb->tc_redirected = 1;
	      ^~
    net/netfilter/nft_fwd_netdev.c:33:10: error: ‘struct sk_buff’ has no member named ‘tc_from_ingress’
      pkt->skb->tc_from_ingress = 1;
	      ^~

Fix this by protecting this code hunk with the appropriate #ifdef.
Sorry about this, and thank you for fixing up this so fast.

I'm attaching an alternative fix to avoid a dependency on tc from
netfilter. Still testing, if fine and no objections I'll formally
submit this.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help