Re: [PATCHv3 bpf-next 0/5] Add bpf_sk_assign eBPF helper

On Sat, Mar 28, 2020 at 10:26 AM Daniel Borkmann [off-list ref] wrote:

On 3/27/20 10:05 PM, Joe Stringer wrote:

quoted

On Fri, Mar 27, 2020 at 11:46 AM Martin KaFai Lau [off-list ref] wrote:

quoted

On Thu, Mar 26, 2020 at 09:25:51PM -0700, Joe Stringer wrote:

quoted

Introduce a new helper that allows assigning a previously-found socket
to the skb as the packet is received towards the stack, to cause the

[...]

quoted

quoted

quoted

Changes since v1:
* Replace the metadata_dst approach with using the skb->destructor to
   determine whether the socket has been prefetched. This is much
   simpler.
* Avoid taking a reference on listener sockets during receive
* Restrict assigning sockets across namespaces
* Restrict assigning SO_REUSEPORT sockets
* Fix cookie usage for socket dst check
* Rebase the tests against test_progs infrastructure
* Tidy up commit messages

lgtm.

Acked-by: Martin KaFai Lau <redacted>

Thanks for the reviews!

I've rolled in the current nits + acks into the branch below, pending
any further feedback. Alexei, happy to respin this on the mailinglist
at some point if that's easier for you.

https://github.com/joestringer/linux/tree/submit/bpf-sk-assign-v3+

Please send the updated series to the list with Martin's ACK retained, so
that we can process the series through our patchwork scripts wrt formatting,
tags etc (please also make sure it's rebased).

Sure thing, will send it out soon.