Thread (29 messages) flat view 29 messages, 7 authors, 2020-03-23

Re: [PATCH RFC v1 03/15] bnxt: add XDP frame size to driver

From: Andy Gospodarek <andy@greyhouse.net>
Date: 2020-03-23 14:18:50
Also in: bpf

On Tue, Mar 17, 2020 at 06:29:22PM +0100, Jesper Dangaard Brouer wrote:
This driver uses full PAGE_SIZE pages when XDP is enabled.
Talked with Jesper about this some more on IRC and he clarified
something for me that was bugging me.
Cc: Michael Chan <michael.chan@broadcom.com>
Cc: Andy Gospodarek <redacted>
I know this is only an RFC, but feel free to add:

Reviewed-by: Andy Gospodarek <redacted>

to this patch.  Thanks for your work on this!
quoted hunk ↗ jump to hunk
Signed-off-by: Jesper Dangaard Brouer <redacted>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
index c6f6f2033880..5e3b4a3b69ea 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
@@ -138,6 +138,7 @@ bool bnxt_rx_xdp(struct bnxt *bp, struct bnxt_rx_ring_info *rxr, u16 cons,
 	xdp_set_data_meta_invalid(&xdp);
 	xdp.data_end = *data_ptr + *len;
 	xdp.rxq = &rxr->xdp_rxq;
+	xdp.frame_sz = PAGE_SIZE; /* BNXT_RX_PAGE_MODE(bp) when XDP enabled */
 	orig_data = xdp.data;
 
 	rcu_read_lock();
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help