Re: [PATCH bpf-next 3/6] bpf: implement bpf_link-based cgroup BPF program attachment
From: Stanislav Fomichev <sdf@fomichev.me>
Date: 2020-03-20 21:33:20
Also in:
bpf
On 03/20, Andrii Nakryiko wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index 5d01c5c7e598..fad9f79bb8f1 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/bpf.h@@ -111,6 +111,7 @@ enum bpf_cmd { BPF_MAP_LOOKUP_AND_DELETE_BATCH, BPF_MAP_UPDATE_BATCH, BPF_MAP_DELETE_BATCH,
[..]
+ BPF_LINK_CREATE,
Curious, why did you decide to add new command versus reusing existing BPF_PROG_ATTACH/BPF_PROG_DETACH pair? Can we have a new flag like BPF_F_NOT_OWNED that we can set when calling BPF_PROG_ATTACH to trigger all these new bpf_link properties (like cgroup not holding an extra ref)?