Re: [PATCH] vhost: vdpa: remove unnecessary null check
From: Jason Wang <jasowang@redhat.com>
Date: 2020-03-31 02:36:16
Also in:
kvm, lkml, virtualization
From: Jason Wang <jasowang@redhat.com>
Date: 2020-03-31 02:36:16
Also in:
kvm, lkml, virtualization
On 2020/3/31 上午7:50, Gustavo A. R. Silva wrote:
container_of is never null, so this null check is unnecessary. Addresses-Coverity-ID: 1492006 ("Logically dead code") Fixes: 20453a45fb06 ("vhost: introduce vDPA-based backend") Signed-off-by: Gustavo A. R. Silva <redacted> --- drivers/vhost/vdpa.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 421f02a8530a..3d2cb811757a 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c@@ -678,8 +678,6 @@ static int vhost_vdpa_open(struct inode *inode, struct file *filep) int nvqs, i, r, opened; v = container_of(inode->i_cdev, struct vhost_vdpa, cdev); - if (!v) - return -ENODEV; opened = atomic_cmpxchg(&v->opened, 0, 1); if (opened)
Acked-by: Jason Wang <jasowang@redhat.com> Thanks