Thread (38 messages) flat view 38 messages, 8 authors, 2020-03-27

Re: [patch V3 12/20] powerpc/ps3: Convert half completion to rcuwait

From: Geoff Levand <geoff@infradead.org>
Date: 2020-03-27 19:15:00
Also in: linux-acpi, linux-pci, linux-pm, linux-usb, linux-wireless, linuxppc-dev, lkml, platform-driver-x86

Hi,

On 3/21/20 4:25 AM, Thomas Gleixner wrote:
From: Thomas Gleixner <redacted>

The PS3 notification interrupt and kthread use a hacked up completion to
communicate. Since we're wanting to change the completion implementation and
this is abuse anyway, replace it with a simple rcuwait since there is only ever
the one waiter.

AFAICT the kthread uses TASK_INTERRUPTIBLE to not increase loadavg, kthreads
cannot receive signals by default and this one doesn't look different. Use
TASK_IDLE instead.
I tested the patch set applied against v5.6-rc7 on the PS3 and it worked
as expected.

Tested by: Geoff Levand [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help