Re: [PATCH net-next v2 12/12] ethtool: provide timestamping information with TIMESTAMP_GET request
From: Richard Cochran <richardcochran@gmail.com>
Date: 2020-03-27 18:56:18
Also in:
lkml
On Fri, Mar 27, 2020 at 03:08:17PM +0100, Michal Kubecek wrote:
+/* TIMESTAMP */
+
+enum {
+ ETHTOOL_A_TIMESTAMP_UNSPEC,I suggest using ETHTOOL_A_TSINFO_ throughout. After all, this API does not provide time stamps, and we want to avoid confusion.
+ ETHTOOL_A_TIMESTAMP_HEADER, /* nest - _A_HEADER_* */ + ETHTOOL_A_TIMESTAMP_TIMESTAMPING, /* bitset */ + ETHTOOL_A_TIMESTAMP_TX_TYPES, /* bitset */ + ETHTOOL_A_TIMESTAMP_RX_FILTERS, /* bitset */ + ETHTOOL_A_TIMESTAMP_PHC_INDEX, /* u32 */ + + /* add new constants above here */ + __ETHTOOL_A_TIMESTAMP_CNT, + ETHTOOL_A_TIMESTAMP_MAX = (__ETHTOOL_A_TIMESTAMP_CNT - 1) +};
Acked-by: Richard Cochran <richardcochran@gmail.com>