Thread (24 messages) 24 messages, 11 authors, 2020-03-31

Re: [PATCH 4/4] dt-bindings: Add missing 'additionalProperties: false'

From: Lee Jones <hidden>
Date: 2020-03-27 08:31:14
Also in: dri-devel, linux-amlogic, linux-arm-kernel, linux-arm-msm, linux-clk, linux-devicetree, linux-gpio, linux-iio, linux-media, linux-pm, lkml

On Wed, 25 Mar 2020, Rob Herring wrote:
Setting 'additionalProperties: false' is frequently omitted, but is
important in order to check that there aren't extra undocumented
properties in a binding.

Ideally, we'd just add this automatically and make this the default, but
there's some cases where it doesn't work. For example, if a common
schema is referenced, then properties in the common schema aren't part
of what's considered for 'additionalProperties'. Also, sometimes there
are bus specific properties such as 'spi-max-frequency' that go into
bus child nodes, but aren't defined in the child node's schema.

So let's stick with the json-schema defined default and add
'additionalProperties: false' where needed. This will be a continual
review comment and game of wack-a-mole.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/arm/altera/socfpga-clk-manager.yaml    | 2 ++
 .../bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml       | 2 ++
 Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml       | 2 ++
 Documentation/devicetree/bindings/arm/renesas,prr.yaml         | 2 ++
 .../devicetree/bindings/arm/samsung/exynos-chipid.yaml         | 2 ++
 Documentation/devicetree/bindings/arm/samsung/pmu.yaml         | 2 ++
 .../bindings/arm/samsung/samsung-secure-firmware.yaml          | 2 ++
 .../devicetree/bindings/arm/stm32/st,stm32-syscon.yaml         | 2 ++
 Documentation/devicetree/bindings/clock/fsl,plldig.yaml        | 2 ++
 Documentation/devicetree/bindings/clock/imx8mn-clock.yaml      | 2 ++
 Documentation/devicetree/bindings/clock/imx8mp-clock.yaml      | 2 ++
 Documentation/devicetree/bindings/clock/milbeaut-clock.yaml    | 2 ++
 Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml  | 2 ++
 Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml  | 2 ++
 Documentation/devicetree/bindings/clock/qcom,gcc-msm8996.yaml  | 2 ++
 Documentation/devicetree/bindings/clock/qcom,gcc-msm8998.yaml  | 2 ++
 Documentation/devicetree/bindings/clock/qcom,gcc-qcs404.yaml   | 2 ++
 Documentation/devicetree/bindings/clock/qcom,gcc-sc7180.yaml   | 2 ++
 Documentation/devicetree/bindings/clock/qcom,gcc-sm8150.yaml   | 2 ++
 Documentation/devicetree/bindings/clock/qcom,gcc.yaml          | 2 ++
 Documentation/devicetree/bindings/clock/qcom,mmcc.yaml         | 2 ++
 .../devicetree/bindings/clock/qcom,msm8998-gpucc.yaml          | 2 ++
 Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml       | 2 ++
 .../devicetree/bindings/clock/qcom,sc7180-dispcc.yaml          | 2 ++
 Documentation/devicetree/bindings/clock/qcom,sc7180-gpucc.yaml | 2 ++
 .../devicetree/bindings/clock/qcom,sc7180-videocc.yaml         | 2 ++
 .../devicetree/bindings/clock/qcom,sdm845-dispcc.yaml          | 2 ++
 Documentation/devicetree/bindings/clock/qcom,sdm845-gpucc.yaml | 2 ++
 .../devicetree/bindings/clock/qcom,sdm845-videocc.yaml         | 2 ++
 .../devicetree/bindings/display/amlogic,meson-vpu.yaml         | 2 ++
 .../devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml        | 2 ++
 Documentation/devicetree/bindings/dsp/fsl,dsp.yaml             | 2 ++
 Documentation/devicetree/bindings/eeprom/at24.yaml             | 2 ++
 .../firmware/intel,ixp4xx-network-processing-engine.yaml       | 3 +++
 .../devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml          | 2 ++
 .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml      | 2 ++
 Documentation/devicetree/bindings/gpio/xylon,logicvc-gpio.yaml | 2 ++
 Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml    | 2 ++
 Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml    | 2 ++
 Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml     | 2 ++
 Documentation/devicetree/bindings/gpu/samsung-rotator.yaml     | 2 ++
 Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml       | 2 ++
 Documentation/devicetree/bindings/hwmon/adi,ltc2947.yaml       | 2 ++
 Documentation/devicetree/bindings/hwmon/pmbus/ti,ucd90320.yaml | 2 ++
 Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml         | 2 ++
 Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml  | 2 ++
 Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml      | 2 ++
 Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml      | 2 ++
 Documentation/devicetree/bindings/iio/adc/lltc,ltc2496.yaml    | 2 ++
 .../devicetree/bindings/iio/adc/microchip,mcp3911.yaml         | 2 ++
 .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml        | 2 ++
 .../devicetree/bindings/iio/chemical/plantower,pms7003.yaml    | 2 ++
 .../devicetree/bindings/iio/chemical/sensirion,sps30.yaml      | 2 ++
 Documentation/devicetree/bindings/iio/dac/lltc,ltc1660.yaml    | 2 ++
 Documentation/devicetree/bindings/iio/light/adux1020.yaml      | 2 ++
 Documentation/devicetree/bindings/iio/light/bh1750.yaml        | 2 ++
 Documentation/devicetree/bindings/iio/light/isl29018.yaml      | 2 ++
 Documentation/devicetree/bindings/iio/light/noa1305.yaml       | 2 ++
 Documentation/devicetree/bindings/iio/light/stk33xx.yaml       | 2 ++
 Documentation/devicetree/bindings/iio/light/tsl2583.yaml       | 2 ++
 Documentation/devicetree/bindings/iio/light/tsl2772.yaml       | 2 ++
 Documentation/devicetree/bindings/iio/light/veml6030.yaml      | 2 ++
 .../devicetree/bindings/iio/pressure/asc,dlhl60d.yaml          | 2 ++
 Documentation/devicetree/bindings/iio/pressure/bmp085.yaml     | 2 ++
 .../devicetree/bindings/iio/proximity/devantech-srf04.yaml     | 2 ++
 .../devicetree/bindings/iio/proximity/parallax-ping.yaml       | 2 ++
 .../devicetree/bindings/iio/temperature/adi,ltc2983.yaml       | 2 ++
 Documentation/devicetree/bindings/input/gpio-vibrator.yaml     | 2 ++
 Documentation/devicetree/bindings/input/max77650-onkey.yaml    | 3 +++
 .../bindings/interrupt-controller/intel,ixp4xx-interrupt.yaml  | 2 ++
 Documentation/devicetree/bindings/iommu/samsung,sysmmu.yaml    | 2 ++
 Documentation/devicetree/bindings/leds/leds-max77650.yaml      | 3 +++
 Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml  | 3 +++
 .../devicetree/bindings/mailbox/amlogic,meson-gxbb-mhu.yaml    | 2 ++
 Documentation/devicetree/bindings/media/amlogic,gx-vdec.yaml   | 2 ++
 .../devicetree/bindings/media/amlogic,meson-gx-ao-cec.yaml     | 2 ++
 Documentation/devicetree/bindings/media/renesas,ceu.yaml       | 2 ++
 Documentation/devicetree/bindings/mfd/max77650.yaml            | 2 ++
 Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml   | 2 ++
Acked-by: Lee Jones <redacted>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help