Re: [PATCH net-next 6/9] net: phy: add backplane kr driver support
From: Joe Perches <joe@perches.com>
Date: 2020-03-26 18:57:13
Also in:
linux-devicetree, linux-doc, lkml
From: Joe Perches <joe@perches.com>
Date: 2020-03-26 18:57:13
Also in:
linux-devicetree, linux-doc, lkml
On Thu, 2020-03-26 at 11:53 -0700, David Miller wrote:
From: Florinel Iordache <redacted> Date: Thu, 26 Mar 2020 15:51:19 +0200quoted
+static void kr_reset_master_lane(struct kr_lane_info *krln) +{ + struct phy_device *bpphy = krln->bpphy; + struct backplane_phy_info *bp_phy = bpphy->priv; + const struct lane_io_ops *lane_ops = krln->bp_phy->bp_dev.lane_ops;Please use reverse christmas tree ordering for local variables.
How (any why) do you suggest the first 2 entries here should be ordered?