Re: [PATCH] net: qmi_wwan: add support for ASKEY WWHC050
From: Bjørn Mork <bjorn@mork.no>
Date: 2020-03-19 07:07:42
Also in:
linux-usb, lkml
Pawel Dembicki [off-list ref] writes:
[add commit message]
Forgot to delete that line? :-)
--- drivers/net/usb/qmi_wwan.c | 1 + drivers/usb/serial/option.c | 2 ++ 2 files changed, 3 insertions(+)
You need to split this in two patches. The drivers are in two different subsystems.
quoted hunk
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 5754bb6ca0ee..6c738a271257 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c@@ -1210,6 +1210,7 @@ static const struct usb_device_id products[] = { {QMI_FIXED_INTF(0x1435, 0xd182, 5)}, /* Wistron NeWeb D18 */ {QMI_FIXED_INTF(0x1435, 0xd191, 4)}, /* Wistron NeWeb D19Q1 */ {QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)}, /* Fibocom NL668 series */ + {QMI_FIXED_INTF(0x1690, 0x7588, 4)}, /* ASKEY WWHC050 */ {QMI_FIXED_INTF(0x16d8, 0x6003, 0)}, /* CMOTech 6003 */ {QMI_FIXED_INTF(0x16d8, 0x6007, 0)}, /* CMOTech CHE-628S */ {QMI_FIXED_INTF(0x16d8, 0x6008, 0)}, /* CMOTech CMU-301 */
I know it isn't perfect as it is, but please try to sort new entries by vid/pid if possible. Keep any logical grouping of entries though, of that applies. Thanks Bjørn