Re: [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked()
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Date: 2020-03-11 03:26:56
Also in:
alsa-devel, bpf, lkml
Hi, On Wed, Mar 11, 2020 at 01:09:08AM +0000, Jules Irenge wrote:
Sparse reports a warning at tscm_hwdep_read_locked() warning: context imbalance in tscm_hwdep_read_locked() - unexpected unlock The root cause is the missing annotation at tscm_hwdep_read_locked() Add the missing __releases(&tscm->lock) annotation Signed-off-by: Jules Irenge <redacted> --- sound/firewire/tascam/tascam-hwdep.c | 1 + 1 file changed, 1 insertion(+)
Thanks for your care of the warning. Although I have found it, I had no idea to suppress it. Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
quoted hunk ↗ jump to hunk
diff --git a/sound/firewire/tascam/tascam-hwdep.c b/sound/firewire/tascam/tascam-hwdep.c index 9801e33e7f2a..6f38335fe10b 100644 --- a/sound/firewire/tascam/tascam-hwdep.c +++ b/sound/firewire/tascam/tascam-hwdep.c@@ -17,6 +17,7 @@ static long tscm_hwdep_read_locked(struct snd_tscm *tscm, char __user *buf, long count, loff_t *offset) + __releases(&tscm->lock) { struct snd_firewire_event_lock_status event = { .type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS,-- 2.24.1