Thread (8 messages) 8 messages, 5 authors, 2020-03-12

Re: [PATCH v4 2/2] net: memcg: late association of sock to memcg

From: Roman Gushchin <hidden>
Date: 2020-03-10 22:39:43
Also in: cgroups, linux-mm, lkml

On Mon, Mar 09, 2020 at 10:16:06PM -0700, Shakeel Butt wrote:
If a TCP socket is allocated in IRQ context or cloned from unassociated
(i.e. not associated to a memcg) in IRQ context then it will remain
unassociated for its whole life. Almost half of the TCPs created on the
system are created in IRQ context, so, memory used by such sockets will
not be accounted by the memcg.

This issue is more widespread in cgroup v1 where network memory
accounting is opt-in but it can happen in cgroup v2 if the source socket
for the cloning was created in root memcg.

To fix the issue, just do the association of the sockets at the accept()
time in the process context and then force charge the memory buffer
already used and reserved by the socket.

Signed-off-by: Shakeel Butt <redacted>
Reviewed-by: Roman Gushchin <redacted>

Thank you!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help