Thread (34 messages) 34 messages, 3 authors, 2020-03-06

Re: [PATCH bpf-next v3 03/12] bpf: tcp: move assertions into tcp_bpf_get_proto

flat view

From: Jakub Sitnicki <jakub@cloudflare.com>
Date: 2020-03-05 12:10:33
Also in: bpf, lkml

On Wed, Mar 04, 2020 at 11:13 AM CET, Lorenz Bauer wrote:
We need to ensure that sk->sk_prot uses certain callbacks, so that
code that directly calls e.g. tcp_sendmsg in certain corner cases
works. To avoid spurious asserts, we must to do this only if
sk_psock_update_proto has not yet been called. The same invariants
apply for tcp_bpf_check_v6_needs_rebuild, so move the call as well.

Doing so allows us to merge tcp_bpf_init and tcp_bpf_reinit.

Signed-off-by: Lorenz Bauer <redacted>
---
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>

[...]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help