Thread (9 messages) 9 messages, 5 authors, 2020-02-07

Re: [PATCH bpf] bpf: Improve bucket_log calculation logic

flat view

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2020-02-07 22:05:02
Also in: bpf

On 2/7/20 9:18 AM, Martin KaFai Lau wrote:
It was reported that the max_t, ilog2, and roundup_pow_of_two macros have
exponential effects on the number of states in the sparse checker.

This patch breaks them up by calculating the "nbuckets" first so
that the "bucket_log" only needs to take ilog2().

Fixes: 6ac99e8f23d4 ("bpf: Introduce bpf sk local storage")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Luc Van Oostenryck <redacted>
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Martin KaFai Lau <redacted>
Applied (& improved changelog to clarify it's not just sparse), thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help