RE: [Intel-wired-lan] [PATCH][next] ice: remove redundant assignment to pointer vsi
flat view
From: Allan, Bruce W <hidden>
Date: 2020-02-25 19:16:40
Also in:
intel-wired-lan, kernel-janitors, lkml
-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of
Colin King
Sent: Saturday, February 22, 2020 9:11 AM
To: Kirsher, Jeffrey T <redacted>; David S . Miller
[off-list ref]; intel-wired-lan@lists.osuosl.org;
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [Intel-wired-lan] [PATCH][next] ice: remove redundant assignment to
pointer vsi
From: Colin Ian King <redacted>
Pointer vsi is being re-assigned a value that is never read,
the assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")What version of coverity and what options were used?
quoted hunk ↗ jump to hunk
Signed-off-by: Colin Ian King <redacted> --- drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.cb/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c index 169b72a94b9d..2c8e334c47a0 100644--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c@@ -2191,7 +2191,6 @@ static int ice_vc_ena_qs_msg(struct ice_vf *vf, u8*msg) set_bit(vf_q_id, vf->rxq_ena); } - vsi = pf->vsi[vf->lan_vsi_idx]; q_map = vqs->tx_queues; for_each_set_bit(vf_q_id, &q_map, ICE_MAX_BASE_QS_PER_VF) { if (!ice_vc_isvalid_q_id(vf, vqs->vsi_id, vf_q_id)) { -- 2.25.0 _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan