Thread (8 messages) 8 messages, 4 authors, 2020-02-25

Re: [PATCH bpf-next v6 1/2] virtio_net: keep vnet header zeroed if XDP is loaded for small buffer

From: Jason Wang <hidden>
Date: 2020-02-25 05:45:11
Also in: bpf, lkml

On 2020/2/25 上午11:32, Yuya Kusakabe wrote:
quoted hunk ↗ jump to hunk
We do not want to care about the vnet header in receive_small() if XDP
is loaded, since we can not know whether or not the packet is modified
by XDP.

Fixes: f6b10209b90d ("virtio-net: switch to use build_skb() for small buffer")
Signed-off-by: Yuya Kusakabe <redacted>
---
  drivers/net/virtio_net.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 2fe7a3188282..f39d0218bdaa 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -735,10 +735,10 @@ static struct sk_buff *receive_small(struct net_device *dev,
  	}
  	skb_reserve(skb, headroom - delta);
  	skb_put(skb, len);
-	if (!delta) {
+	if (!xdp_prog) {
  		buf += header_offset;
  		memcpy(skb_vnet_hdr(skb), buf, vi->hdr_len);
-	} /* keep zeroed vnet hdr since packet was changed by bpf */
+	} /* keep zeroed vnet hdr since XDP is loaded */
  
  err:
  	return skb;

Acked-by: Jason Wang <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help