Thread (6 messages) 6 messages, 4 authors, 2020-02-24

Re: [PATCH v6 1/2] net: mdio: add ipq8064 mdio driver

From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: 2020-02-23 20:19:36
Also in: linux-arm-msm, linux-devicetree, lkml

On Sun, Feb 23, 2020 at 12:47:40AM +0100, Christian Lamparter wrote:
quoted
+static int
+ipq8064_mdio_read(struct mii_bus *bus, int phy_addr, int reg_offset)
+{
+	struct ipq8064_mdio *priv = bus->priv;
+	u32 miiaddr = MII_BUSY | MII_CLKRANGE_250_300M;
+	u32 ret_val;
+	int err;
+
+	/* Reject clause 45 */
+	if (reg_offset & MII_ADDR_C45)
+		return -EOPNOTSUPP;
Heh, C45 on IPQ806X? Ok, anyone know the hardware or is this some fancy
forward-thinking future-proofing?
Quite simply, the driver as written does not support C45, so it should
reject it, rather than truncating the "reg_offset" and issuing C22
cycles instead.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help