Thread (3 messages) 3 messages, 3 authors, 2020-02-21

Re: [PATCH net-next] net/mlx5: Fix header guard in rsc_dump.h

From: Jason Gunthorpe <hidden>
Date: 2020-02-21 13:30:06
Also in: linux-rdma, lkml

On Thu, Feb 20, 2020 at 10:24:37PM -0700, Nathan Chancellor wrote:
Clang warns:

 In file included from
 ../drivers/net/ethernet/mellanox/mlx5/core/main.c:73:
 ../drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h:4:9: warning:
 '__MLX5_RSC_DUMP_H' is used as a header guard here, followed by #define
 of a different macro [-Wheader-guard]
 #ifndef __MLX5_RSC_DUMP_H
         ^~~~~~~~~~~~~~~~~
 ../drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h:5:9: note:
 '__MLX5_RSC_DUMP__H' is defined here; did you mean '__MLX5_RSC_DUMP_H'?
 #define __MLX5_RSC_DUMP__H
         ^~~~~~~~~~~~~~~~~~
         __MLX5_RSC_DUMP_H
 1 warning generated.
Wow, that is a neat warning

Reviewed-by: Jason Gunthorpe <redacted>

Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help