Thread (24 messages) 24 messages, 2 authors, 2020-02-23
STALE2335d

[patch V2 03/20] bpf/tracing: Remove redundant preempt_disable() in __bpf_trace_run()

From: Thomas Gleixner <hidden>
Date: 2020-02-20 20:56:53
Also in: bpf, lkml

__bpf_trace_run() disables preemption around the BPF_PROG_RUN() invocation.

This is redundant because __bpf_trace_run() is invoked from a trace point
via __DO_TRACE() which already disables preemption _before_ invoking any of
the functions which are attached to a trace point.

Remove it.

Signed-off-by: Thomas Gleixner <redacted>
---
 kernel/trace/bpf_trace.c |    2 --
 1 file changed, 2 deletions(-)
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c
@@ -1476,9 +1476,7 @@ static __always_inline
 void __bpf_trace_run(struct bpf_prog *prog, u64 *args)
 {
 	rcu_read_lock();
-	preempt_disable();
 	(void) BPF_PROG_RUN(prog, args);
-	preempt_enable();
 	rcu_read_unlock();
 }
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help