Thread (12 messages) flat view 12 messages, 4 authors, 2020-06-19

Re: [PATCH 1/2] net: qrtr: Migrate nameservice to kernel from userspace

From: David Miller <davem@davemloft.net>
Date: 2020-02-17 02:56:03
Also in: lkml

From: Manivannan Sadhasivam <redacted>
Date: Thu, 13 Feb 2020 14:44:26 +0530
+static int service_announce_new(struct sockaddr_qrtr *dest,
+				struct qrtr_server *srv)
+{
+	struct qrtr_ctrl_pkt pkt;
+	struct msghdr msg = { };
+	struct kvec iv = { &pkt, sizeof(pkt) };
Please use reverse christmas tree ordering for local variables.

Please fix this for your entire submission.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help